fix: Correct bugs in multiple value enum option help text #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several issues introduced in f1a8455: 1. ReflectionHelper.IsEnumerableType - The implementation had bugs: - type.IsAssignableTo(typeof(IEnumerable<>)) doesn't work for open generics - type.GenericTypeArguments[1] was wrong (arrays have element at index 0) Rewrote to properly handle arrays and generic types. 2. DefaultHelpTextGenerator.ExtractNamesFromEnum - Used wrong variable name (wrappedType2 instead of wrappedEnumerableType). 3. ValueParserProvider.GetParserImpl - Added array type support so app.Option<SomeEnum[]>() works with MultipleValue options. 4. Test expectation - Fixed expected help text format for MultipleValue options (--enumOpt5 <E> not --enumOpt5[:<E>]). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 21, 2026
Closed
Merged
Open
Closed
This was referenced Jan 28, 2026
This was referenced Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
app.Option<SomeEnum[]>()withMultipleValueoptionsReflectionHelper.IsEnumerableTypeto properly detect array element typesExtractNamesFromEnum(wrappedType2→wrappedEnumerableType)ValueParserProvider.GetParserImplTest plan
DefaultHelpTextGeneratorTests.ShowHelpnow correctly testsOption<SomeEnum[]>withMultipleValue🤖 Generated with Claude Code